[#16705] - refactor: remove has() check in doGet().#16709
Merged
Conversation
niden
requested changes
Mar 5, 2025
kunal-lottostar
approved these changes
Mar 7, 2025
Member
|
@noone-silent Can you rebase please. The changelog entry needs to go to 5.9.1 This looks good. |
# Conflicts: # CHANGELOG-5.0.md
Contributor
Author
done |
niden
approved these changes
Mar 20, 2025
Member
|
Thank you @noone-silent |
|
I've created a bug report in relation to this one, but this is causing issues with adapters that do not do existence checks within themselves or return false naturally. One issue here is the cached value is actually a PHP @niden I think this may need to be reverted unless a quick fix can be implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
hasCall ingetMethod Slowing Down Redis #16705In raising this pull request, I confirm the following:
Small description of change: Remove the
has()check indoGet()Thanks