T13648 firewall#14078
Merged
Merged
Conversation
Member
Author
|
cc @sergeyklay |
sergeyklay
previously approved these changes
May 15, 2019
Jurigag
previously approved these changes
May 15, 2019
Jurigag
left a comment
Contributor
There was a problem hiding this comment.
Looks fine, needs to implement all those added tests which my branch didn't cover.
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14078 +/- ##
==========================================
+ Coverage 70.75% 71.13% +0.38%
==========================================
Files 479 479
Lines 93829 93836 +7
==========================================
+ Hits 66385 66747 +362
+ Misses 27444 27089 -355
Continue to review full report at Codecov.
|
This was referenced May 15, 2019
Closed
Member
|
Awesome!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
this pr is adding Firewall component, way to protect routes against unauthorized roles to access certain routes. It's done using listener on dispatcher/micro on beforeExecute/afterBinding event.
In dispatcher you can either use Annotations or Acl based firewall. In micro there is only Acl based firewall.
Would appreciate any comments etc.
This PR is commits/changes from other PRs etc stuff so don't bother them, i will rebase everything if all will be merged.
Thanks
Related:
#11389
#582
Based on work from @Jurigag #12561
Thanks