-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[NFR]: Need the lock for redis session #17126
Copy link
Copy link
Closed
Labels
5.0The issues we want to solve in the 5.0 releaseThe issues we want to solve in the 5.0 releasenew feature requestPlanned Feature or New Feature RequestPlanned Feature or New Feature Request
Metadata
Metadata
Assignees
Labels
5.0The issues we want to solve in the 5.0 releaseThe issues we want to solve in the 5.0 releasenew feature requestPlanned Feature or New Feature RequestPlanned Feature or New Feature Request
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Implemented
Hi guys,
I think we need to implement a lock for the Redis session.
Without it may cause some unexpected bugs, like login failed,
because of the login request may take a little longer time to init some user data,
but the next request has arrived at the time.
There may have many ways to deal with this, using phpredis's session locking
phpredis session locking
or just add a new method to the session manager to give the chance for some check.
Exp: