Drop th-lift-instances dependency#11
Closed
ysangkok wants to merge 1 commit intophadej:masterfrom
ysangkok:janus/drop-th-instances
Closed
Drop th-lift-instances dependency#11ysangkok wants to merge 1 commit intophadej:masterfrom ysangkok:janus/drop-th-instances
ysangkok wants to merge 1 commit intophadej:masterfrom
ysangkok:janus/drop-th-instances
Conversation
Owner
with GHC-7.8.4 I guess at this point it's fine to drop GHC-7.x support. I'll do it in #12. |
This was referenced Aug 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my local tests, it doesn't seem like removing this dependency breaks any builds, including GHC 7.10.
th-lift mentions that only GHC 8.0 should have "largely" made th-lift superfluous, so I am unsure which parts are missing in 7.10.
If this dependency can't be removed yet, it would be nice to expand the tests to have them cover this.