perf: avoid extra query on every new connection (regression since 42.5.2, PR#2556)#2826
Merged
davecramer merged 2 commits intopgjdbc:masterfrom Feb 20, 2023
Merged
Conversation
* Add box to TypeInfoCache, fixes Issue pgjdbc#2746 * use semi-colon delimiter for box type * Fix: regression in PgResultSet LONG_MIN copy paste error fixes Issue pgjdbc#2748 (pgjdbc#2749)
…to search for box type but it is now cached (pgjdbc#2810) fix OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2556 introduced a regression. The regression was that a query was added on every new connection.
The fix for this was to add the box type to the cache, however that caused 2 tests to fail.
This PR addresses these issues