put entry in CHANGELOG and release notes for 42.5.0#2601
Conversation
|
|
||
| [42.5.0] (2022-08-23 11:20:11 -0400) | ||
| ### Changed | ||
| - fix: revert change in [PR #1986](https://github.com/pgjdbc/pgjdbc/pull/1986) where float was aliased to float4 from float8. |
There was a problem hiding this comment.
Is the "-" prefix for the revert line intentional? Otherwise rest looks fine.
There was a problem hiding this comment.
Yes, is intentional, when is rendered in markdown it looks like a
- bullet point
|
|
||
| ### Fixed | ||
|
|
||
| [42.5.0] (2022-08-23 11:20:11 -0400) |
There was a problem hiding this comment.
Versions should start as a header with the prefix ##
## [42.5.0] (2022-08-23 11:20:11 -0400)
(42.4.1 and 42.4.2 have the same issue)
|
|
||
| ### Added | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
If the sections Added and Fixed are empty we can remove them.
| [42.4.1]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.2 | ||
| [Unreleased]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.2...HEAD | ||
| [42.4.2]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.2...REL42.5.0 | ||
| [Unreleased]: https://github.com/pgjdbc/pgjdbc/compare/REL42.5.0...HEAD |
There was a problem hiding this comment.
I have missed this in previous versions but the comparison order should be:
[VERSION]: .../compare/REL_PREVIOUS_VERSION...REL_VERSION (the final REL should match the linked version)
We have a duplicate version 42.3.4, and from there the versions are mixed.
Deleting all the lines since 42.3.4 (including the duplicate) and adding this should fix it:
[42.3.4]: https://github.com/pgjdbc/pgjdbc/compare/REL42.3.3...REL42.3.4
[42.3.5]: https://github.com/pgjdbc/pgjdbc/compare/REL42.3.4...REL42.3.5
[42.3.6]: https://github.com/pgjdbc/pgjdbc/compare/REL42.3.5...REL42.3.6
[42.4.0]: https://github.com/pgjdbc/pgjdbc/compare/REL42.3.6...REL42.4.0
[42.4.1]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.0...REL42.4.1
[42.4.2]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.2
[42.5.0]: https://github.com/pgjdbc/pgjdbc/compare/REL42.4.2...REL42.5.0
[Unreleased]: https://github.com/pgjdbc/pgjdbc/compare/REL42.5.0...HEAD
|
@jorsol looks good ? I'd like to release this today if possible. |
No description provided.