chore: bump Gradle to 7.4.2 by vlsi · Pull Request #2535 · pgjdbc/pgjdbc

vlsi · 2022-06-05T16:37:54Z

This enables building with Java 17

TODO:

KarafFeaturesTask property 'karaf' is missing an input or output annotation lburgazzoli/gradle-karaf-plugin#80

vlsi · 2022-06-10T18:51:01Z

/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/gss/MakeGSS.java:20: warning: [removal] AccessController in java.security has been deprecated and marked for removal
import java.security.AccessController;
                    ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/Driver.java:27: warning: [removal] AccessController in java.security has been deprecated and marked for removal
import java.security.AccessController;
                    ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java:1627: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
    SecurityManager securityManager = System.getSecurityManager();
    ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java:1627: warning: [removal] getSecurityManager() in System has been deprecated and marked for removal
    SecurityManager securityManager = System.getSecurityManager();
                                            ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/gss/MakeGSS.java:52: warning: [removal] AccessController in java.security has been deprecated and marked for removal
      Subject sub = Subject.getSubject(AccessController.getContext());
                                       ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/gss/MakeGSS.java:52: warning: [removal] getSubject(AccessControlContext) in Subject has been deprecated and marked for removal
      Subject sub = Subject.getSubject(AccessController.getContext());
                           ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/Driver.java:91: warning: [removal] AccessController in java.security has been deprecated and marked for removal
          AccessController.doPrivileged(new PrivilegedExceptionAction<Properties>() {
          ^
/home/runner/work/pgjdbc/pgjdbc/pgjdbc/src/main/java/org/postgresql/Driver.java:274: warning: [removal] AccessControlException in java.security has been deprecated and marked for removal
    } catch (java.security.AccessControlException ace) {
                          ^

Subject.getSubject(AccessController.getContext()); will be replaced with a static Subject.current().

Any preferences on how we should tackle that?

a) Use SuppressWarnings. It would work, however, the code would break in Java 18
b) Rewrite with reflection (or MethodHandles)
c) add "comment preprocessor" and different class files for different Java versions.
d) use different source files for different Java versions

I'm inclined to a or b

davecramer · 2022-06-11T11:19:20Z

I'd prefer the solution that will work in the future. So B
That said I wonder how it will play with graal ?

vlsi · 2022-06-11T11:21:12Z

wonder how it will play with graal ?

GraalVM supports MethodHandle: oracle/graal#2761

davecramer · 2022-06-11T11:28:28Z

wonder how it will play with graal ?

GraalVM supports MethodHandle: oracle/graal#2761

Then by all means solve this problem in such a way that it will work in the future.

vlsi · 2022-06-12T08:24:31Z

Need to apply https://github.com/bndtools/bnd/pull/3904/files somehow

Build pgjdbc FAILURE reason:                                
    Execution failed for task ':postgresql:osgiJar':
        java.util.ConcurrentModificationException
            at aQute.bnd.osgi.Jar.putResource(Jar.java:335)
            at aQute.bnd.osgi.Jar.buildFromZip(Jar.java:263)
            at aQute.bnd.osgi.Jar.<init>(Jar.java:128)
            at aQute.bnd.osgi.Jar.<init>(Jar.java:219)
            at aQute.bnd.gradle.BundleTaskConvention$_buildBundle_closure5$_closure6.doCall(BundleTaskConvention.groovy:244)
            at org.apache.groovy.nio.extensions.NioExtensions.withCloseable(NioExtensions.java:1927)
            at aQute.bnd.gradle.BundleTaskConvention$_buildBundle_closure5.doCall(BundleTaskConvention.groovy:199)
at org.gradle.util.internal.ClosureBackedAction.execute(ClosureBackedAction.java:72)
at org.gradle.util.internal.ConfigureUtil.configureTarget(ConfigureUtil.java:155)
at org.gradle.util.internal.ConfigureUtil.configureSelf(ConfigureUtil.java:131)
at org.gradle.api.internal.AbstractTask.configure(AbstractTask.java:669)
at org.gradle.api.DefaultTask.configure(DefaultTask.java:309)
at org.gradle.api.DefaultTask.configure(DefaultTask.java:45)
            at aQute.bnd.gradle.BundleTaskConvention.buildBundle(BundleTaskConvention.groovy:194)
at org.gradle.internal.metaobject.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:484)
at org.gradle.internal.metaobject.BeanDynamicObject.tryInvokeMethod(BeanDynamicObject.java:196)
at org.gradle.internal.extensibility.DefaultConvention$ExtensionsDynamicObject.tryInvokeMethod(DefaultConvention.java:[308](https://github.com/pgjdbc/pgjdbc/runs/6848672098?check_suite_focus=true#step:8:313))
at org.gradle.internal.metaobject.CompositeDynamicObject.tryInvokeMethod(CompositeDynamicObject.java:98)
at org.gradle.internal.extensibility.MixInClosurePropertiesAsMethodsDynamicObject.tryInvokeMethod(MixInClosurePropertiesAsMethodsDynamicObject.java:34)
at org.gradle.internal.metaobject.AbstractDynamicObject.invokeMethod(AbstractDynamicObject.java:163)
            at aQute.bnd.gradle.Bundle.copy(Bundle.groovy:52)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:104)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:242)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:68)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:227)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:210)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.java:193)
at org.gradle.api.internal.tasks.execution.TaskExecution.execute(TaskExecution.java:171)
at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:89)
at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:40)
at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:53)
at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:50)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:50)
at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:40)
at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:68)
at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:38)
at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:48)
at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:36)
at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:41)
at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:74)
at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55)
at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:51)
at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:29)
at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:61)
at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:42)
at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:60)
at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:27)
at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:180)
at org.gradle.internal.execution.steps.BuildCacheStep.lambda$execute$1(BuildCacheStep.java:75)
at org.gradle.internal.Either$Right.fold(Either.java:175)
at org.gradle.internal.execution.caching.CachingState.fold(CachingState.java:59)
at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:73)
at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:48)
at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:36)
at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:25)
at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:36)
at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:22)
at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:110)
at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$2(SkipUpToDateStep.java:56)
at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:56)
at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:38)
at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:73)
at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:44)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27)
at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:89)
at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:50)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:114)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:57)
at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:76)
at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:50)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.executeWithNoEmptySources(SkipEmptyWorkStep.java:249)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.executeWithNoEmptySources(SkipEmptyWorkStep.java:204)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:83)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:54)
at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:32)
at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:21)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)
at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:43)
at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:31)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.lambda$execute$0(AssignWorkspaceStep.java:40)
at org.gradle.api.internal.tasks.execution.TaskExecution$4.withWorkspace(TaskExecution.java:287)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:40)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:30)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:37)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:27)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:44)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:33)

vlsi · 2022-06-12T18:01:05Z

This looks mergeable to me.
I'm not fond of all those try-catch-MethodHandle stuff, however, there are only a couple of cases, so it is not that bad.

… reflection

The finalize is deprecated for removal in Java 17+, so add suppress warnings to unlock build under Java 17+

We treat javadoc warnings as build errors, however, it looks like recent Java starts requiring javadoc for everything.

…odificationException See bndtools/bnd#3904

rp

…m to 4.13.5 to avoid illegal reflective access

vlsi force-pushed the gradle7 branch from b90cd60 to e98b278 Compare June 5, 2022 16:38

vlsi mentioned this pull request Jun 9, 2022

chore: add randomized CI matrix for PR tests #2534

Merged

4 tasks

vlsi force-pushed the gradle7 branch 3 times, most recently from d88b28a to 8e8d899 Compare June 10, 2022 16:30

vlsi force-pushed the gradle7 branch 6 times, most recently from 4c8e9d3 to 6870af3 Compare June 12, 2022 08:18

vlsi force-pushed the gradle7 branch 6 times, most recently from 60ace06 to 7eb5d85 Compare June 12, 2022 17:53

vlsi added 7 commits June 17, 2022 13:43

chore: bump Gradle to 7.4.2

3657bdb

chore: fix usages of deprecated Gradle API

9337e53

chore: support building pgjdbc with Java 17

d92b014

java 18: replace direct usages of java.security.AccessController with…

d40af3d

… reflection

suppress use of finalize in StreamWrapper

3ff4197

The finalize is deprecated for removal in Java 17+, so add suppress warnings to unlock build under Java 17+

chore: skip "missing javadoc" warning

de748b2

We treat javadoc warnings as build errors, however, it looks like recent Java starts requiring javadoc for everything.

chore: bump biz.aQute.bnd.builder 4.3.1 -> 6.3.1 to avoid ConcurrentM…

f92804c

…odificationException See bndtools/bnd#3904

vlsi added 5 commits June 17, 2022 13:43

chore: fix usages of Gradle 7 deprecated APIs

1d9fa7c

chore: bump me.champeau.jmh to 0.6.6 to fix Gradle deprecation warnings

b1bc5db

chore: bump jandex-plugin to 1.82 to fix Gradle 7 warnings

3774a50

rp

chore: bump org.apache.felix.framework to 7.0.5 and org.ops4j.pax.exa…

abd462f

…m to 4.13.5 to avoid illegal reflective access

Bump com.github.autostyle to 3.2 to fix Gradle deprecation warnings

386813e

vlsi force-pushed the gradle7 branch from 7eb5d85 to 386813e Compare June 17, 2022 10:43

vlsi merged commit 386813e into pgjdbc:master Jun 17, 2022

Rob4001 mentioned this pull request Aug 12, 2022

42.4.1 JDK18 GSS compat getCurrentSubject WrongMethodTypeException #2588

Closed

vlsi deleted the gradle7 branch November 14, 2022 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump Gradle to 7.4.2#2535

chore: bump Gradle to 7.4.2#2535
vlsi merged 12 commits into
pgjdbc:masterfrom
vlsi:gradle7

vlsi commented Jun 5, 2022 •

edited

Loading

Uh oh!

vlsi commented Jun 10, 2022

Uh oh!

davecramer commented Jun 11, 2022

Uh oh!

vlsi commented Jun 11, 2022

Uh oh!

davecramer commented Jun 11, 2022

Uh oh!

vlsi commented Jun 12, 2022

Uh oh!

vlsi commented Jun 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vlsi commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vlsi commented Jun 10, 2022

Uh oh!

davecramer commented Jun 11, 2022

Uh oh!

vlsi commented Jun 11, 2022

Uh oh!

davecramer commented Jun 11, 2022

Uh oh!

vlsi commented Jun 12, 2022

Uh oh!

vlsi commented Jun 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vlsi commented Jun 5, 2022 •

edited

Loading