feat: support upload s3 by http#2587
Closed
Wenne wants to merge 2 commits intopgbackrest:integrationfrom
Closed
Conversation
Author
|
#2571 |
dwsteele
requested changes
Mar 27, 2025
Member
dwsteele
left a comment
There was a problem hiding this comment.
This is definitely much more like what we are looking for. See my comment, though.
Also, why did you open a new PR? In the future please just make changes to the existing branch/PR. It is a lot less confusing.
|
|
||
| const String* const protocol = httpUrlProtocolType(url) == httpProtocolTypeHttp ? | ||
| STRDEF("http") : STRDEF("https"); | ||
|
|
Member
There was a problem hiding this comment.
Why do this -- why not just use httpProtocolTypeHttps and httpProtocolTypeHttp?
Member
|
Also, tests are definitely not happy: https://github.com/pgbackrest/pgbackrest/actions/runs/14105373523 |
Member
|
Closing this PR in favor of #2703. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read Submitting a Pull Request before submitting.