Skip to content

Conversation

@pgaskin
Copy link
Owner

@pgaskin pgaskin commented Aug 11, 2020

The navigation changes in 4.23.15505 caused a few actions to break.

closes #79

@pgaskin pgaskin force-pushed the pgaskin/fw-15505-actions branch from 2c122fe to cadd1e0 Compare August 11, 2020 23:14
@pgaskin pgaskin marked this pull request as ready for review August 11, 2020 23:52
Copy link
Owner Author

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as part of #79 in the pgaskin/fw-15505-experiements branch. Has also been tested to ensure there aren't any regressions on older firmware versions and that it works properly from all menus, especially for the nickel_open:library:* action.

Config:

#!/bin/sh

rm -rf /mnt/onboard/.adds/nm
mkdir /mnt/onboard/.adds/nm
cd /mnt/onboard/.adds/nm

# after testing, run: rm /mnt/onboard/.adds/nm/config; mv /mnt/onboard/.adds/nm/1.swp /mnt/onboard/.adds/nm/1

cat <<'EOF' > config
invalid
EOF

# then, cycle through the menus and test the items (in any order)

cat <<'EOF' > 1.swp
menu_item :main    :1  :cmd_spawn          :sleep 10s
menu_item :reader  :1  :cmd_spawn          :sleep 10s
menu_item :browser :1  :cmd_spawn          :sleep 10s
menu_item :library :1  :cmd_spawn          :sleep 10s
menu_item :main    :2  :cmd_spawn          :quiet:sleep 10s
menu_item :reader  :2  :cmd_spawn          :quiet:sleep 10s
menu_item :browser :2  :cmd_spawn          :quiet:sleep 10s
menu_item :library :2  :cmd_spawn          :quiet:sleep 10s
menu_item :main    :3  :cmd_output         :500:logread|tac
menu_item :reader  :3  :cmd_output         :500:logread|tac
menu_item :browser :3  :cmd_output         :500:logread|tac
menu_item :library :3  :cmd_output         :500:logread|tac
menu_item :main    :4  :cmd_output         :500:quiet:logread|tac
menu_item :reader  :4  :cmd_output         :500:quiet:logread|tac
menu_item :browser :4  :cmd_output         :500:quiet:logread|tac
menu_item :library :4  :cmd_output         :500:quiet:logread|tac
menu_item :main    :N1 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/1 /mnt/onboard/.adds/nm/1.swp; mv /mnt/onboard/.adds/nm/2.swp /mnt/onboard/.adds/nm/2
chain_success          :dbg_toast          :N2/9
EOF

cat <<'EOF' > 2.swp
menu_item :main    :5  :dbg_syslog         :test
menu_item :reader  :5  :dbg_syslog         :test
menu_item :browser :5  :dbg_syslog         :test
menu_item :library :5  :dbg_syslog         :test
menu_item :main    :6  :dbg_error          :test
menu_item :reader  :6  :dbg_error          :test
menu_item :browser :6  :dbg_error          :test
menu_item :library :6  :dbg_error          :test
menu_item :main    :7  :dbg_msg            :test
menu_item :reader  :7  :dbg_msg            :test
menu_item :browser :7  :dbg_msg            :test
menu_item :library :7  :dbg_msg            :test
menu_item :main    :8  :dbg_toast          :test
menu_item :reader  :8  :dbg_toast          :test
menu_item :browser :8  :dbg_toast          :test
menu_item :library :8  :dbg_toast          :test
menu_item :main    :N2 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/2 /mnt/onboard/.adds/nm/2.swp; mv /mnt/onboard/.adds/nm/3.swp /mnt/onboard/.adds/nm/3
chain_success          :dbg_toast          :N3/9
EOF

cat <<'EOF' > 3.swp
menu_item :main    :9  :kfmon              :test.png
menu_item :reader  :9  :kfmon              :test.png
menu_item :browser :9  :kfmon              :test.png
menu_item :library :9  :kfmon              :test.png
menu_item :main    :10 :nickel_setting     :toggle:invert
menu_item :reader  :10 :nickel_setting     :toggle:invert
menu_item :browser :10 :nickel_setting     :toggle:invert
menu_item :library :10 :nickel_setting     :toggle:invert
menu_item :main    :11 :nickel_setting     :toggle:lockscreen
menu_item :reader  :11 :nickel_setting     :toggle:lockscreen
menu_item :browser :11 :nickel_setting     :toggle:lockscreen
menu_item :library :11 :nickel_setting     :toggle:lockscreen
menu_item :main    :12 :nickel_setting     :toggle:screenshots
menu_item :reader  :12 :nickel_setting     :toggle:screenshots
menu_item :browser :12 :nickel_setting     :toggle:screenshots
menu_item :library :12 :nickel_setting     :toggle:screenshots
menu_item :main    :13 :nickel_setting     :toggle:force_wifi
menu_item :reader  :13 :nickel_setting     :toggle:force_wifi
menu_item :browser :13 :nickel_setting     :toggle:force_wifi
menu_item :library :13 :nickel_setting     :toggle:force_wifi
menu_item :main    :14 :nickel_setting     :toggle:auto_usb_gadget
menu_item :reader  :14 :nickel_setting     :toggle:auto_usb_gadget
menu_item :browser :14 :nickel_setting     :toggle:auto_usb_gadget
menu_item :library :14 :nickel_setting     :toggle:auto_usb_gadget
menu_item :main    :N3 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/3 /mnt/onboard/.adds/nm/3.swp; mv /mnt/onboard/.adds/nm/4.swp /mnt/onboard/.adds/nm/4
chain_success          :dbg_toast          :N4/9
EOF

cat <<'EOF' > 4.swp
menu_item :main    :15 :nickel_extras      :unblock_it
menu_item :reader  :15 :nickel_extras      :unblock_it
menu_item :browser :15 :nickel_extras      :unblock_it
menu_item :library :15 :nickel_extras      :unblock_it
menu_item :main    :16 :nickel_extras      :sketch_pad
menu_item :reader  :16 :nickel_extras      :sketch_pad
menu_item :browser :16 :nickel_extras      :sketch_pad
menu_item :library :16 :nickel_extras      :sketch_pad
menu_item :main    :17 :nickel_extras      :solitaire
menu_item :reader  :17 :nickel_extras      :solitaire
menu_item :browser :17 :nickel_extras      :solitaire
menu_item :library :17 :nickel_extras      :solitaire
menu_item :main    :18 :nickel_extras      :sudoku
menu_item :reader  :18 :nickel_extras      :sudoku
menu_item :browser :18 :nickel_extras      :sudoku
menu_item :library :18 :nickel_extras      :sudoku
menu_item :main    :19 :nickel_extras      :word_scramble
menu_item :reader  :19 :nickel_extras      :word_scramble
menu_item :browser :19 :nickel_extras      :word_scramble
menu_item :library :19 :nickel_extras      :word_scramble
menu_item :main    :20 :nickel_browser     :
menu_item :reader  :20 :nickel_browser     :
menu_item :browser :20 :nickel_browser     :
menu_item :library :20 :nickel_browser     :
menu_item :main    :21 :nickel_browser     :https://pgaskin.net
menu_item :reader  :21 :nickel_browser     :https://pgaskin.net
menu_item :browser :21 :nickel_browser     :https://pgaskin.net
menu_item :library :21 :nickel_browser     :https://pgaskin.net
menu_item :main    :22 :nickel_browser     :https://pgaskin.net *{background:black}
menu_item :reader  :22 :nickel_browser     :https://pgaskin.net *{background:black}
menu_item :browser :22 :nickel_browser     :https://pgaskin.net *{background:black}
menu_item :library :22 :nickel_browser     :https://pgaskin.net *{background:black}
menu_item :main    :23 :nickel_browser     :modal
menu_item :reader  :23 :nickel_browser     :modal
menu_item :browser :23 :nickel_browser     :modal
menu_item :library :23 :nickel_browser     :modal
menu_item :main    :24 :nickel_browser     :modal:https://pgaskin.net
menu_item :reader  :24 :nickel_browser     :modal:https://pgaskin.net
menu_item :browser :24 :nickel_browser     :modal:https://pgaskin.net
menu_item :library :24 :nickel_browser     :modal:https://pgaskin.net
menu_item :main    :25 :nickel_browser     :modal:https://pgaskin.net *{background:black}
menu_item :reader  :25 :nickel_browser     :modal:https://pgaskin.net *{background:black}
menu_item :browser :25 :nickel_browser     :modal:https://pgaskin.net *{background:black}
menu_item :library :25 :nickel_browser     :modal:https://pgaskin.net *{background:black}
menu_item :main    :N4 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/4 /mnt/onboard/.adds/nm/4.swp; mv /mnt/onboard/.adds/nm/5.swp /mnt/onboard/.adds/nm/5
chain_success          :dbg_toast          :N5/9
EOF

cat <<'EOF' > 5.swp
menu_item :main    :26 :nickel_misc        :home
menu_item :reader  :26 :nickel_misc        :home
menu_item :browser :26 :nickel_misc        :home
menu_item :library :26 :nickel_misc        :home
menu_item :main    :27 :nickel_misc        :force_usb_connection
menu_item :reader  :27 :nickel_misc        :force_usb_connection
menu_item :browser :27 :nickel_misc        :force_usb_connection
menu_item :library :27 :nickel_misc        :force_usb_connection
menu_item :main    :28 :nickel_misc        :rescan_books
menu_item :reader  :28 :nickel_misc        :rescan_books
menu_item :browser :28 :nickel_misc        :rescan_books
menu_item :library :28 :nickel_misc        :rescan_books
menu_item :main    :29 :nickel_misc        :rescan_books_full
menu_item :reader  :29 :nickel_misc        :rescan_books_full
menu_item :browser :29 :nickel_misc        :rescan_books_full
menu_item :library :29 :nickel_misc        :rescan_books_full
menu_item :main    :N5 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/5 /mnt/onboard/.adds/nm/5.swp; mv /mnt/onboard/.adds/nm/6.swp /mnt/onboard/.adds/nm/6
chain_success          :dbg_toast          :N6/9
EOF

cat <<'EOF' > 6.swp
menu_item :main    :30 :nickel_open        :discover:storefront
menu_item :reader  :30 :nickel_open        :discover:storefront
menu_item :browser :30 :nickel_open        :discover:storefront
menu_item :library :30 :nickel_open        :discover:storefront
menu_item :main    :31 :nickel_open        :discover:wishlist
menu_item :reader  :31 :nickel_open        :discover:wishlist
menu_item :browser :31 :nickel_open        :discover:wishlist
menu_item :library :31 :nickel_open        :discover:wishlist
menu_item :main    :32 :nickel_open        :library:library
menu_item :reader  :32 :nickel_open        :library:library
menu_item :browser :32 :nickel_open        :library:library
menu_item :library :32 :nickel_open        :library:library
menu_item :main    :33 :nickel_open        :library:library2
menu_item :reader  :33 :nickel_open        :library:library2
menu_item :browser :33 :nickel_open        :library:library2
menu_item :library :33 :nickel_open        :library:library2
menu_item :main    :34 :nickel_open        :library:all
menu_item :reader  :34 :nickel_open        :library:all
menu_item :browser :34 :nickel_open        :library:all
menu_item :library :34 :nickel_open        :library:all
menu_item :main    :35 :nickel_open        :library:authors
menu_item :reader  :35 :nickel_open        :library:authors
menu_item :browser :35 :nickel_open        :library:authors
menu_item :library :35 :nickel_open        :library:authors
menu_item :main    :36 :nickel_open        :library:series
menu_item :reader  :36 :nickel_open        :library:series
menu_item :browser :36 :nickel_open        :library:series
menu_item :library :36 :nickel_open        :library:series
menu_item :main    :37 :nickel_open        :library:shelves
menu_item :reader  :37 :nickel_open        :library:shelves
menu_item :browser :37 :nickel_open        :library:shelves
menu_item :library :37 :nickel_open        :library:shelves
menu_item :main    :38 :nickel_open        :library:pocket
menu_item :reader  :38 :nickel_open        :library:pocket
menu_item :browser :38 :nickel_open        :library:pocket
menu_item :library :38 :nickel_open        :library:pocket
menu_item :main    :39 :nickel_open        :library:dropbox
menu_item :reader  :39 :nickel_open        :library:dropbox
menu_item :browser :39 :nickel_open        :library:dropbox
menu_item :library :39 :nickel_open        :library:dropbox
menu_item :main    :40 :nickel_open        :reading_life:reading_life
menu_item :reader  :40 :nickel_open        :reading_life:reading_life
menu_item :browser :40 :nickel_open        :reading_life:reading_life
menu_item :library :40 :nickel_open        :reading_life:reading_life
menu_item :main    :41 :nickel_open        :reading_life:stats
menu_item :reader  :41 :nickel_open        :reading_life:stats
menu_item :browser :41 :nickel_open        :reading_life:stats
menu_item :library :41 :nickel_open        :reading_life:stats
menu_item :main    :42 :nickel_open        :reading_life:awards
menu_item :reader  :42 :nickel_open        :reading_life:awards
menu_item :browser :42 :nickel_open        :reading_life:awards
menu_item :library :42 :nickel_open        :reading_life:awards
menu_item :main    :43 :nickel_open        :reading_life:words
menu_item :reader  :43 :nickel_open        :reading_life:words
menu_item :browser :43 :nickel_open        :reading_life:words
menu_item :library :43 :nickel_open        :reading_life:words
menu_item :main    :44 :nickel_open        :store:overdrive
menu_item :reader  :44 :nickel_open        :store:overdrive
menu_item :browser :44 :nickel_open        :store:overdrive
menu_item :library :44 :nickel_open        :store:overdrive
menu_item :main    :45 :nickel_open        :store:search
menu_item :reader  :45 :nickel_open        :store:search
menu_item :browser :45 :nickel_open        :store:search
menu_item :library :45 :nickel_open        :store:search
menu_item :main    :N6 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/6 /mnt/onboard/.adds/nm/6.swp; mv /mnt/onboard/.adds/nm/7.swp /mnt/onboard/.adds/nm/7
chain_success          :dbg_toast          :N7/9
EOF

cat <<'EOF' > 7.swp
menu_item :main    :46 :nickel_wifi        :autoconnect
menu_item :reader  :46 :nickel_wifi        :autoconnect
menu_item :browser :46 :nickel_wifi        :autoconnect
menu_item :library :46 :nickel_wifi        :autoconnect
menu_item :main    :47 :nickel_wifi        :autoconnect_silent
menu_item :reader  :47 :nickel_wifi        :autoconnect_silent
menu_item :browser :47 :nickel_wifi        :autoconnect_silent
menu_item :library :47 :nickel_wifi        :autoconnect_silent
menu_item :main    :48 :nickel_wifi        :enable
menu_item :reader  :48 :nickel_wifi        :enable
menu_item :browser :48 :nickel_wifi        :enable
menu_item :library :48 :nickel_wifi        :enable
menu_item :main    :49 :nickel_wifi        :disable
menu_item :reader  :49 :nickel_wifi        :disable
menu_item :browser :49 :nickel_wifi        :disable
menu_item :library :49 :nickel_wifi        :disable
menu_item :main    :50 :nickel_wifi        :toggle
menu_item :reader  :50 :nickel_wifi        :toggle
menu_item :browser :50 :nickel_wifi        :toggle
menu_item :library :50 :nickel_wifi        :toggle
menu_item :main    :N7 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/7 /mnt/onboard/.adds/nm/7.swp; mv /mnt/onboard/.adds/nm/8.swp /mnt/onboard/.adds/nm/8
chain_success          :dbg_toast          :N8/9
EOF

cat <<'EOF' > 8.swp
menu_item :main    :51 :nickel_orientation :portrait
menu_item :reader  :51 :nickel_orientation :portrait
menu_item :browser :51 :nickel_orientation :portrait
menu_item :library :51 :nickel_orientation :portrait
menu_item :main    :52 :nickel_orientation :landscape
menu_item :reader  :52 :nickel_orientation :landscape
menu_item :browser :52 :nickel_orientation :landscape
menu_item :library :52 :nickel_orientation :landscape
menu_item :main    :53 :nickel_orientation :inverted_portrait
menu_item :reader  :53 :nickel_orientation :inverted_portrait
menu_item :browser :53 :nickel_orientation :inverted_portrait
menu_item :library :53 :nickel_orientation :inverted_portrait
menu_item :main    :54 :nickel_orientation :inverted_landscape
menu_item :reader  :54 :nickel_orientation :inverted_landscape
menu_item :browser :54 :nickel_orientation :inverted_landscape
menu_item :library :54 :nickel_orientation :inverted_landscape
menu_item :main    :55 :nickel_orientation :invert
menu_item :reader  :55 :nickel_orientation :invert
menu_item :browser :55 :nickel_orientation :invert
menu_item :library :55 :nickel_orientation :invert
menu_item :main    :56 :nickel_orientation :swap
menu_item :reader  :56 :nickel_orientation :swap
menu_item :browser :56 :nickel_orientation :swap
menu_item :library :56 :nickel_orientation :swap
menu_item :main    :57 :power              :shutdown
menu_item :reader  :57 :power              :shutdown
menu_item :browser :57 :power              :shutdown
menu_item :library :57 :power              :shutdown
menu_item :main    :58 :power              :reboot
menu_item :reader  :58 :power              :reboot
menu_item :browser :58 :power              :reboot
menu_item :library :58 :power              :reboot
menu_item :main    :59 :power              :sleep
menu_item :reader  :59 :power              :sleep
menu_item :browser :59 :power              :sleep
menu_item :library :59 :power              :sleep
menu_item :main    :N8 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/8 /mnt/onboard/.adds/nm/8.swp; mv /mnt/onboard/.adds/nm/9.swp /mnt/onboard/.adds/nm/9
chain_success          :dbg_toast          :N9/9
EOF

cat <<'EOF' > 9.swp
generator :main    :kfmon
generator :reader  :kfmon
generator :browser :kfmon
generator :library :kfmon
generator :main    :_test :5
generator :reader  :_test :5
generator :browser :_test :5
generator :library :_test :5
generator :main    :_test_time
generator :reader  :_test_time
generator :browser :_test_time
generator :library :_test_time
menu_item :main    :N9 :cmd_output         :500:quiet:mv /mnt/onboard/.adds/nm/9 /mnt/onboard/.adds/nm/9.swp; mv /mnt/onboard/.adds/nm/1.swp /mnt/onboard/.adds/nm/1
chain_success          :dbg_toast          :N1/9
EOF

Devices:

  • Aura2v1 (15505)
  • ClaraHD (15268)
  • ClaraHD (15505, partial)
  • Mini (11655, partial)

@pgaskin pgaskin merged commit a70d09d into master Aug 11, 2020
@pgaskin pgaskin deleted the pgaskin/fw-15505-actions branch August 11, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing compatibility of actions on 4.23.15505

2 participants