Add Instapaper support for latest Kobo firmware v4.43.23418 #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace library:pocket with library:instapaper in nickel_open action - Update symbol to _ZN15LibraryNavMixin21showInstapaperLibraryEv - Update documentation to reflect Instapaper instead of Articles/Pocket - Tested and working on Kobo Libra Colour kobo13 v4.43.23418 firmware
pgaskin
requested changes
Aug 28, 2025
Contributor
Author
|
Hi Patrick @pgaskin. Apologies I'm no C/C++ developer so yes used Sonnet 4 to help me with this change. I've tried to dig through libnickel.so.1.0.0 in the 4.43.23418 firmware but I can't identify a specific version for libnickel itself, so I've updated the comment to 4.43.23418 * (assuming that means that version onwards) in action_cc.cc - I hope that's correct, if not do let me know and also if it's good practice to update the symbol testing tool too. |
|
Thank you, this worked on my Kobo Libra 2 on version 4.38.23429. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent Kobo firmware versions have replaced Pocket with Instapaper. This PR updates NickelMenu to support the new Instapaper functionality.
Changes
library:pocketwithlibrary:instapaperand update symbol to_ZN15LibraryNavMixin21showInstapaperLibraryEvTesting
stringscommand onlibnickel.so.1.0.0Usage