Skip to content

nickel_setting: Print the correct argument on error #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pgaskin merged 1 commit into from
Aug 25, 2021
Merged

nickel_setting: Print the correct argument on error #112

pgaskin merged 1 commit into from
Aug 25, 2021

Conversation

@NiLuJe
Copy link
Collaborator

@NiLuJe NiLuJe commented Aug 24, 2021 •
edited
Loading

Minor typo that came up when people tried to use the dark_mode option on current release builds ;).

c.f., https://www.mobileread.com/forums/showpost.php?p=4148920&postcount=33

@NiLuJe NiLuJe requested a review from pgaskin as a code owner August 24, 2021 18:34
pgaskin
pgaskin approved these changes Aug 25, 2021
View reviewed changes
Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@pgaskin pgaskin merged commit 691203e into master Aug 25, 2021
@pgaskin pgaskin deleted the niluje/nickel_settings-errormsg branch August 25, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgaskin pgaskin pgaskin approved these changes

Assignees

No one assigned

Labels

action bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NiLuJe @pgaskin