Upgrade vendored setuptools to 42.0.2.#832
Merged
jsirois merged 2 commits intopex-tool:masterfrom Dec 27, 2019
Merged
Conversation
The changelogs from 41.6.0 are here: https://setuptools.readthedocs.io/en/latest/history.html#v42-0-2 Of most note are the changes to setuptools to use pip when present to implement `setup_requires`. The way we invoke pip in pex/pip.py is compatible with this new feature; so we get more successful wheel builds as a result. See: pypa/setuptools#1830
Member
Author
|
Reviewers, note that the only manual change here was the single line edit to |
benjyw
approved these changes
Dec 27, 2019
Eric-Arellano
approved these changes
Dec 27, 2019
Contributor
Eric-Arellano
left a comment
There was a problem hiding this comment.
That's great to learn that setuptools is now using Pip for this. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelogs from 41.6.0 are here:
https://setuptools.readthedocs.io/en/latest/history.html#v42-0-2
Of most note are the changes to setuptools to use pip when present
to implement
setup_requires. The way we invoke pip in pex/pip.pyis compatible with this new feature; so we get more successful wheel
builds as a result.
See: pypa/setuptools#1830