Skip to content

Support -c for plat spec dists in multiplat pexes.#545

Merged
jsirois merged 2 commits intopex-tool:masterfrom
jsirois:issues/537
Aug 28, 2018
Merged

Support -c for plat spec dists in multiplat pexes.#545
jsirois merged 2 commits intopex-tool:masterfrom
jsirois:issues/537

Conversation

@jsirois
Copy link
Copy Markdown
Member

@jsirois jsirois commented Aug 25, 2018

Fixes #537

@jsirois
Copy link
Copy Markdown
Member Author

jsirois commented Aug 26, 2018

Eeenteresting. So setuptools 36.2.0+ take install_requires with environment markers and move them to anonymous extras_requires: see here). This 'feature' is only documented here in the wheel docs. I'll back off the un-needed requirement upgrades - just a pytest bump was needed - and file an issue to handle this new wrinkle.

Copy link
Copy Markdown
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsirois jsirois merged commit 983589a into pex-tool:master Aug 28, 2018
@jsirois jsirois deleted the issues/537 branch August 28, 2018 17:25
jsirois added a commit to jsirois/pants that referenced this pull request Oct 11, 2018
This lets the full entry-point live in less places. The `pants` console
script will be much more stable and it's easy to remember / ~obviously
right.

I forgot to leverage the work in
pex-tool/pex#545 when upgrading from
pex 1.4.5 to 1.4.8 as part of pantsbuild#5922.
jsirois added a commit to pantsbuild/pants that referenced this pull request Oct 11, 2018
This lets the full entry-point live in less places. The `pants` console
script will be much more stable and it's easy to remember / ~obviously
right.

I forgot to leverage the work in
pex-tool/pex#545 when upgrading from
pex 1.4.5 to 1.4.8 as part of #5922.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants