Fix NameError in choose_bg_color when color picker is cancelled#84
Merged
petertzy merged 1 commit intopetertzy:mainfrom Feb 18, 2026
Merged
Conversation
When a user cancels the color chooser dialog, text_area was referenced outside the if color: block where it was defined, causing a NameError. Fixed by nesting the text_area usage inside the color check, matching the pattern already used in choose_fg_color.
aeb1f3a to
002ebec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NameErrorcrash becausetext_areais only defined inside theif color:block but referenced outside it on the next line.text_areacheck inside theif color:block, matching the pattern already used bychoose_fg_color().Before (buggy)
After (fixed)
Test plan