fix: don't use configured proxy for unix socket#7
fix: don't use configured proxy for unix socket#7peterbourgon merged 3 commits intomainfrom unknown repository
Conversation
|
@peterbourgon - would you kindly have a chance to consider accepting this change? It's a one-liner, and allows this library to function correctly when run in an environment with a corp proxy. |
peterbourgon
left a comment
There was a problem hiding this comment.
Thanks for the PR. Sorry for missing it originally. It took me a moment to understand what was going on here, I made a few suggestions informed by my journey to understanding. Accept those and I'm happy to merge.
Co-authored-by: Peter Bourgon <peterbourgon@users.noreply.github.com>
Co-authored-by: Peter Bourgon <peterbourgon@users.noreply.github.com>
|
Thanks @peterbourgon - I've accepted the suggestions. We appreciate your library, thanks for maintaining it. |
|
Hi @peterbourgon - would you kindly be able to merge this PR and cut a new release? I accepted the changes which you suggested. Thanks! |
|
Oops! Apologies, fell out of my queue. https://github.com/peterbourgon/unixtransport/releases/tag/v0.0.4 |
|
@ae-govau Please let me know if that doesn't work for you for any reason. |
|
Thanks @peterbourgon ! |
Without this, this module won't work when
https_proxy/http_proxyenvironment variables are set, as these are picked up by the default Go transport clients, and it erroneously tries to the send the connecting through the proxy.We fix by explictly
niling the.Proxysetting after cloning thenet.Transport.