Fix landscape view on mobile devices#234
Merged
Merged
Conversation
Collaborator
Author
|
After two bug reports, one Docusaurus feature request and hours wasted on what I think is just Netlify preview cache messing with me, this is ready for review. I've only tested this on pc and iPhone 12, so someone should test on other devices before merging. Especially landscape mode on device with notch/pinhole or Browerstack (maybe?) if possible. |
Collaborator
|
Awesome job, lots of 🧙♂️. I am only able to test on a very small iPhone and it looks good to me. Personally, I think we should just merge this in and take it from there. What do you say? |
Collaborator
Author
Sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends header, footer etc stretch across the whole screen on devices on devices with camera notches or other non-rectangular screens.
Uses padding with
safe-area-inset-*env-variables set by the device to avoid content being show behind camera etc.Before:
After:
Fix #223