Skip to content

rm some compiler warnings#1093

Merged
tomtau merged 2 commits intopest-parser:masterfrom
yshavit:rm-warnings
Mar 23, 2025
Merged

rm some compiler warnings#1093
tomtau merged 2 commits intopest-parser:masterfrom
yshavit:rm-warnings

Conversation

@yshavit
Copy link
Contributor

@yshavit yshavit commented Mar 22, 2025 •
edited by coderabbitai bot
Loading

  • add lifetime specifier, to remove warnings:

    this elided lifetime gets resolved as `'a

  • mv .cargo/config -> .cargo/config.toml

    From https://doc.rust-lang.org/cargo/reference/config.html:

    Cargo also reads config files without the .toml extension, such as
    .cargo/config. Support for the .toml extension was added in version
    1.39 and is the preferred form. If both files exist, Cargo will use
    the file without the extension.

    This repo's readme says MSRV is 1.65.0, so there's no need to support
    the file without the .toml extension.

Summary by CodeRabbit

  • Refactor
    • Improved internal type handling for filtering and parsing operations.
    • Updated public API return types to enhance consistency and reliability.

These technical improvements ensure enhanced internal stability while maintaining the existing functionality visible to end-users.

yshavit added 2 commits March 22, 2025 18:40
@yshavit
remove warning
f5eba5c 
> this elided lifetime gets resolved as `'a
@yshavit
mv cargo -> cargo.toml
725f567 
From https://doc.rust-lang.org/cargo/reference/config.html:

> Cargo also reads config files without the .toml extension, such as
> .cargo/config. Support for the .toml extension was added in version
> 1.39 and is the preferred form. If both files exist, Cargo will use
> the file without the extension.

This repo's readme says MSRV is 1.65.0, so there's no need to support
the file without the `.toml` extension.
@yshavit yshavit requested a review from a team as a code owner March 22, 2025 22:46
@yshavit yshavit requested review from tomtau and removed request for a team March 22, 2025 22:46
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 22, 2025 •
edited
Loading

Walkthrough

This update refines lifetime annotations in two public methods to enhance type safety and lifetime consistency. In the find_tagged method of the pairs iterator, the closure lifetime is updated from '_ to 'i, and in the parse method of the VM, the returned string slice and error types now share the same lifetime as the input. The core logic of both methods remains unchanged.

Changes

Files Changed Change Summary
pest/src/iterators/pairs.rs, vm/src/lib.rs Updated public method signatures to use more consistent lifetime annotations. In find_tagged, the closure lifetime changed from '_ to 'i; in parse, the return types now consistently use &'a str for both Pairs and error types.

Suggested reviewers

  • NoahTheDuke
  • tomtau

Poem

Oh, I'm a rabbit dancing in the code,
With lifetimes aligned, my skills have glowed!
Carrots and bytes, all in perfect flow,
Hop along safely wherever I go.
Cheers to changes that help us grow!
🐇🥕 Happy coding!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17a7fa0 and 725f567.

📒 Files selected for processing (2)
  • pest/src/iterators/pairs.rs (1 hunks)
  • vm/src/lib.rs (1 hunks)
🔇 Additional comments (2)
vm/src/lib.rs (1)

71-71: Lifetime annotation added to improve clarity and correctness.

The lifetime parameter 'a has been explicitly added to the string slices in the return type (&'a str), ensuring that the returned Pairs and Error have the same lifetime as the input parameters. This change enhances type safety by preventing potential lifetime mismatches.

pest/src/iterators/pairs.rs (1)

330-330: Explicit lifetime annotation replaces elided lifetime in closure.

The lifetime of the closure in the Filter type has been changed from the elided lifetime '_ to 'i, explicitly tying it to the lifetime of the Pairs instance. This enhances type safety by ensuring the closure can safely reference data with the same lifetime as the Pairs instance.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tomtau tomtau merged commit 61f1ebc into pest-parser:master Mar 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomtau tomtau tomtau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yshavit @tomtau