Skip to content

bump toolchain#1090

Merged
tomtau merged 2 commits intomasterfrom
bump-toolchain
Mar 20, 2025
Merged

bump toolchain#1090
tomtau merged 2 commits intomasterfrom
bump-toolchain

Conversation

@tomtau
Copy link
Contributor

@tomtau tomtau commented Mar 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated our automation workflows to use the latest tooling versions, ensuring improved compatibility and build stability.
    • Refined nightly build settings to align with current dependency requirements.
    • Updated documentation to reflect the new minimum supported Rust version of 1.65.

@tomtau tomtau requested a review from a team as a code owner March 20, 2025 23:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2025 •
edited
Loading

Walkthrough

The changes update the Rust toolchain versions in the CI and release workflows. In .github/workflows/ci.yml, multiple jobs have been updated to use toolchain version 1.81.0 instead of earlier stable releases, and the nightly jobs now use nightly-2025-02-20 instead of nightly-2024-11-30. In .github/workflows/release.yml, the toolchain specification has been updated from 1.74.0 to 1.81.0. Additionally, several Cargo.toml files across different packages have been updated to specify a minimum Rust version of 1.65. There are no modifications to any exported or public entities.

Changes

File(s) Change Summary
.github/workflows/ci.yml Updated Rust toolchain versions across jobs: for check, testing, doc, and hack from 1.74.0 → 1.81.0, for dependency from 1.78.0 → 1.81.0, and for no_std and semver from nightly-2024-11-30 → nightly-2025-02-20.
.github/workflows/release.yml Changed the toolchain specification from dtolnay/rust-toolchain@1.74.0 to dtolnay/rust-toolchain@1.81.0 to align with the dependency requirements.
bootstrap/Cargo.toml, debugger/Cargo.toml, derive/Cargo.toml, generator/Cargo.toml, grammars/Cargo.toml, grammars/fuzz/Cargo.toml, meta/Cargo.toml, meta/fuzz/Cargo.toml, pest/Cargo.toml, vm/Cargo.toml Updated rust-version from 1.61 → 1.65 in all specified Cargo.toml files to reflect the new minimum required Rust version.

Possibly related PRs

Suggested reviewers

  • NoahTheDuke

Poem

I'm hopping through branches, light on my feet,
With toolchains updated, everything's neat.
From stable to nightly, my CI's in flight,
Code paths shining in the moonlight.
A bunny cheers with a joyful beat –
Changes made, and all's looking bright! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d80c9d and 0617372.

📒 Files selected for processing (12)
  • .github/actions/setup/action.yml (1 hunks)
  • README.md (2 hunks)
  • bootstrap/Cargo.toml (1 hunks)
  • debugger/Cargo.toml (1 hunks)
  • derive/Cargo.toml (1 hunks)
  • generator/Cargo.toml (1 hunks)
  • grammars/Cargo.toml (1 hunks)
  • grammars/fuzz/Cargo.toml (1 hunks)
  • meta/Cargo.toml (1 hunks)
  • meta/fuzz/Cargo.toml (1 hunks)
  • pest/Cargo.toml (1 hunks)
  • vm/Cargo.toml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • meta/fuzz/Cargo.toml
  • README.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: cargo hack check --feature-powerset
  • GitHub Check: Unit, Style, and Lint Testing
  • GitHub Check: Fuzzing
🔇 Additional comments (10)
derive/Cargo.toml (1)

14-14: Rust Version Update Consistent with Project-wide Bump.
The rust-version = "1.65" update is correctly applied here and aligns with the overall toolchain bump across the repository. Ensure that developers update their local toolchain to Rust 1.65 accordingly.

generator/Cargo.toml (1)

14-14: Updated Rust Version in Generator Module.
The change to rust-version = "1.65" is consistent with similar updates across the project. This update ensures compatibility with the newer Rust features required by current dependencies.

grammars/fuzz/Cargo.toml (1)

6-6: Rust Toolchain Specification Updated.
The update to rust-version = "1.65" meets the new minimum required version and is consistent with the project-wide update. No further changes are necessary here.

debugger/Cargo.toml (1)

17-17: Debugger Package Rust Version Revised.
The rust-version is now set to "1.65", reflecting the standard update across the repository. This change eliminates potential incompatibilities with libraries expecting newer Rust features.

meta/Cargo.toml (1)

22-22: Meta Package Rust Version Update.
The change to rust-version = "1.65" is applied appropriately here and is in line with the global Rust version bump. It is advisable to verify that all dependent crates remain compatible with this updated version.

grammars/Cargo.toml (1)

14-14: Rust Version Update: Correct Bump to "1.65"

The updated rust-version value is consistent with the project-wide upgrade and aligns with the broader toolchain bump objective.

vm/Cargo.toml (1)

14-14: Rust Version Update in VM Package

Updating rust-version to "1.65" ensures consistency with the new minimum requirement across the repository. This change should enable use of newer Rust features and improvements.

pest/Cargo.toml (1)

14-14: Consistent Rust Version Update in Pest Package

The modification of rust-version to "1.65" in this file is consistent with similar changes in other modules. This uniform update helps maintain compatibility and future-proofing across the codebase.

bootstrap/Cargo.toml (1)

12-12: Bootstrap Package: Rust Version Bump

Changing the rust-version to "1.65" aligns the bootstrap package with the rest of the project. It’s recommended to verify the bootstrap scripts’ compatibility with newer Rust features, though the change appears straightforward.

.github/actions/setup/action.yml (1)

11-11: Workflow Action Update: Default Toolchain Version

Updating the default toolchain input to "1.65.0" in this action ensures that the CI setup remains consistent with the updated Rust version requirements specified in the Cargo.toml files. This change meets the overall toolchain bump objective.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tomtau tomtau enabled auto-merge (squash) March 20, 2025 23:35
@tomtau tomtau merged commit b1869d5 into master Mar 20, 2025
9 checks passed
@tomtau tomtau deleted the bump-toolchain branch March 20, 2025 23:47
@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jun 9, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tomtau