Skip to content

Band-Aid: fix one of the left recursion bugs (fixes #1047)#1048

Merged
tomtau merged 3 commits intopest-parser:masterfrom
Tartasprint:master
Oct 18, 2024
Merged

Band-Aid: fix one of the left recursion bugs (fixes #1047)#1048
tomtau merged 3 commits intopest-parser:masterfrom
Tartasprint:master

Conversation

@Tartasprint
Copy link
Contributor

@Tartasprint Tartasprint commented Oct 18, 2024 •
edited by coderabbitai bot
Loading

This is a band-aid. Comments in the code indicate that left recursion validation has probably other edge cases/bugs.

This fixes #1047 and successfully detects the left-recursion. Here is the output message when running cargo build:

error: proc-macro derive panicked
 --> src\main.rs:4:10
  |
4 | #[derive(Parser)]
  |          ^^^^^^
  |
  = help: message: grammar error

           --> 1:19
            |
          1 | expr = { !(EOI) ~ expr ~ "infix" ~ expr }
            |                   ^--^
            |
            = rule expr is left-recursive (expr -> expr); pest::pratt_parser might be useful in this case

Summary by CodeRabbit

  • New Features

    • Enhanced validation for parser rules to better detect potential left recursion issues, improving parsing reliability.

  • Bug Fixes

    • Refined logic in the validation process to catch more cases of infinite repetitions or non-terminating behavior in grammar rules.

@Tartasprint Tartasprint requested a review from a team as a code owner October 18, 2024 01:16
@Tartasprint Tartasprint requested review from tomtau and removed request for a team October 18, 2024 01:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2024 •
edited
Loading

Walkthrough

The changes involve an update to the validate_left_recursion function in the meta/src/validator.rs file. The update refines the logic for detecting left recursion in parser rules by adding a check for non-progressing expressions alongside the existing non-failing check. This modification is intended to improve the detection of potential left recursion issues, which can lead to infinite parsing loops.

Changes

File Change Summary
meta/src/validator.rs Modified the logic in validate_left_recursion to include a check for non-progressing expressions in addition to non-failing expressions.

Assessment against linked issues

Objective Addressed Explanation
Improve detection of left recursion to prevent stack overflow (#1047) ✅

Suggested reviewers

  • tomtau

Poem

In fields of code where bunnies play,
We fixed the rules, come what may.
No more loops that spin and spin,
With logic sharp, let parsing begin! 🐇✨
Hopping forward, we’ve made it right,
A grammar’s dance, a joyful sight!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c93aae8 and 3ae5eba.

📒 Files selected for processing (1)
  • meta/src/validator.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • meta/src/validator.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

tomtau
tomtau requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; could you add a simple test case that captures that original issue?

MSRV failing seems unrelated to this PR (it's just that it failed to fetch cargo-msrv's binary for some reason)

tomtau
tomtau approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@tomtau tomtau merged commit e457389 into pest-parser:master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomtau tomtau tomtau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stack overflow achieved with left recursion undetected

2 participants

@Tartasprint @tomtau