Skip to content

[API Proxy Commands] URL Mapping Configuration #108

Merged
gemanor merged 63 commits intopermitio:mainfrom
harshtech123:main
Apr 24, 2025
Merged

[API Proxy Commands] URL Mapping Configuration #108
gemanor merged 63 commits intopermitio:mainfrom
harshtech123:main

Conversation

@harshtech123
Copy link
Copy Markdown
Contributor

Pull Request

Description

this pr aims to implement proxy commands

Implementation Details

Commands are:

  • permit api list proxy
  • permit api create proxy

/closes #102

Type of Change

  • Bug fix
  • New feature/command
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition/update
  • Other (please describe):

Checklist

  • I have created an issue and linked it in this PR
  • I have created a branch from main with an appropriate name (e.g., fix/issue-123, feature/new-command)
  • My code follows the project's coding style guidelines
  • I have added tests for my changes (>90% coverage of new code)
  • I have updated the documentation if necessary
  • All tests pass locally
  • Lint checks pass locally
  • I have reviewed my own code for potential issues

New Command Details (if applicable)

  • Command is placed in the src/commands directory
  • Command file contains only argument configuration and a root command component
  • Command is wrapped with the AuthProvider component
  • Command has an optional apiKey argument
  • API key scope is declared for the command
  • Documentation added to the README

Additional Notes

Screenshots/Recordings

Copy link
Copy Markdown
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great start!

It needs some refactoring in:

  • The utilization of the AuthProvider and the utilization of useClient
  • The mapping rules argument and wizards

Copy link
Copy Markdown
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job there! Haven't tested the functionality yet, but left all comments on the experience. Please LMK when done, so I'll run some tests on the functionality.

Copy link
Copy Markdown
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gemanor gemanor merged commit 4dd40ea into permitio:main Apr 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Commands] URL Mapping Configuration

2 participants