feat(test): implement 'test run audit' command#93
Merged
gemanor merged 23 commits intopermitio:mainfrom Apr 10, 2025
Merged
Conversation
gemanor
reviewed
Apr 1, 2025
Collaborator
gemanor
left a comment
There was a problem hiding this comment.
The is generally good, but it mismatches the API clients.
- Make sure you're using only API clients from
useClientand not custom built ones fromfetchUtilandlib/api - In the same manner, all the scope handling in the component is redundant. It's against the guidelines to do API calls from the component
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
gemanor
requested changes
Apr 6, 2025
Collaborator
gemanor
left a comment
There was a problem hiding this comment.
I think there are some gaps in the implementations that need to clarify. Left some comments.
- Improve error handling to display actual error details to users - Remove redundant scope fetching as it's handled by API client - Add proper support for ABAC and ReBAC in check functions - Enhance PDP request generation to properly handle resource keys and IDs - Add proper handling of user and resource attributes in PDP requests
Collaborator
Author
|
|
Collaborator
Author
|
npx tsx ./source/cli.tsx pdp run |
9e0ec78 to
53e472c
Compare
gemanor
approved these changes
Apr 10, 2025
Collaborator
gemanor
left a comment
There was a problem hiding this comment.
Clean and comprehensive code! Well done
|
🎉🎈 @daveads has been awarded $2,000 by Permit.io! 🎈🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new command to compare historical audit logs against a running PDP. The command:
Features:
Closes this issue >>> #72