Skip to content

Woff fonts missing (corrupt on asset discovery capture)  #222

@NouranMahmoud

Description

@NouranMahmoud

Hi,

I was trying to integrate Percy with our product but I faced two issues. so, to reproduce the issue I created this simple AngularApp with protractor, and integrated Percy on it with a simple test.

The two issues are

First: This cli error keeps showing up often (not always), it seems there is a race condition somewhere.

[percy] Waiting for 1 snapshot(s) to finish uploading
[percy] Encountered an error uploading snapshot: buttons
[percy] Error: write EPIPE
    Error: Finalizing build 10984130 failed: cannot finalize before all snapshot resources are 
    uploaded. This is likely a client error, please make sure that content for all SHAs in 
    'missing-resources' from the snapshot response are uploaded before calling finalize.
npm ERR! code ELIFECYCLE
npm ERR! errno 1

The script that I use to run percy is
PERCY_PARALLEL_TOTAL=0 npm run percy:run
"percy:run": "LOG_LEVEL=debug npx percy exec -t 1000 -- npm run e2e"

Second: local assets are not loaded
As you can see in the AngApp, I have font and icon files locally, these files are ignored and don't get uploaded to Percy so the screenshot looks broken.

Screenshots of expected and what I get in the Percy build dashboard

Expected:
Local environment app
https://ibb.co/vB3KQ0S

Actual:
Percy broken screenshot
https://ibb.co/XJGDWdR

PercyClient: In this line the assets which is part of (resources) variable gets filtered and it seems only missing-resources array gets uploaded

Hopefully, this AngProject clarify the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    🐛 bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions