fix: Static service wait for network idle (#270)

Robdel12 · web-flow · commit 7d438d2ccfc8 · 2019-07-02T10:39:59.000-05:00
I've been seeing a lot of errors like:

```
Error: Execution context was destroyed, most likely because of a navigation.
```

This happens because we try to start altering the page (by injecting our JS)
before everything is settled down. This change won't promise the page has
actually loaded (that's very hard to determine) but it will wait for most
network requests to resolve before trying do anything.
diff --git a/src/services/static-snapshot-service.ts b/src/services/static-snapshot-service.ts
@@ -49,7 +49,7 @@ export default class StaticSnapshotService {
     for (const url of pageUrls) {
       logger.debug(`visiting ${url}`)
 
-      await page.goto(url)
+      await page.goto(url, { waitUntil: 'networkidle0' })
 
       await page.addScriptTag({
         path: percyAgentClientFilename,
