Merged
Conversation
Robdel12
approved these changes
Aug 13, 2021
| 'will be removed in 1.0.0. Use `discovery.requestHeaders` instead.' | ||
| expect(mocked.migrate.deprecate).toEqual([ | ||
| ['snapshot.authorization', { map: 'discovery.authorization', type: 'config', in: '1.0.0' }], | ||
| ['snapshot.requestHeaders', { map: 'discovery.requestHeaders', type: 'config', in: '1.0.0' }] |
Contributor
There was a problem hiding this comment.
Wonder if we should open an issue like "v1.0.0 deprecations" and list the various deprecations we've made/make sure to remove?
Contributor
Author
There was a problem hiding this comment.
That's a good idea.
341a583 to
7098d50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
We currently only have a single place where config migrations log a few deprecation warnings, and that is in
@percy/core. We also had/have deprecations in the Storybook SDK, although that SDK recently left beta and so the deprecations are/will be removed. In the future, other config deprecations might come up, and so it would be helpful to consolidate how deprecations are handled into a single migrate util passed along just like the other current migrate utils.This PR also updates
@percy/coremigration deprecations to use the new util.Depends on #493 as these changes are how I discovered those bugs.