fixing test coverage for serialize iframes#2137
Merged
bhokaremoin merged 2 commits intomasterfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the serializeFrames test suite to cover additional iframe srcdoc serialization scenarios, specifically around Trusted Types availability and error handling when setting attributes.
Changes:
- Added a test ensuring
srcdocserialization still works whenwindow.trustedTypesis unavailable (fallback path). - Added a test ensuring serialization does not throw if
setAttribute('srcdoc', ...)throws.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prklm10
approved these changes
Mar 10, 2026
prklm10
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new tests to the
serializeFramessuite to improve robustness and error handling around iframe serialization. The main focus is ensuring that serialization works correctly without Trusted Types and that errors insetAttributeare handled gracefully.Improvements to iframe serialization robustness:
srcdocserialization works correctly even whenwindow.trustedTypesis not available, ensuring fallback behavior is reliable.setAttribute(specifically for thesrcdocattribute) are handled gracefully and do not break serialization, improving error resilience.