fix: Validate width range and escape percyElementId in RegExp for widths-config endpoint#2123
Closed
Copilot wants to merge 2 commits intoPPLT-4949-add-cors-iframe-handling-and-multi-dom-width-configfrom
Closed
Conversation
Co-authored-by: bhokaremoin <75439850+bhokaremoin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add responsive widths config endpoint and CORS iframe processing
fix: Validate width range and escape percyElementId in RegExp for widths-config endpoint
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two security/correctness issues identified in the
/percy/widths-configendpoint and CORS iframe processing.Changes
Width range validation (
api.js): User-suppliedwidthsquery params were only filtered forNaN. Addedw >= 120 && w <= 2000to match the same constraints enforced by the config schema — preventing out-of-range values (e.g.-50,100,2001) from reaching snapshot capture.RegExp injection fix (
utils.js):iframeData.percyElementIdwas interpolated directly into aRegExppattern, enabling regex injection and potential catastrophic backtracking from user-controlled input. Replaced thenosemgrepsuppression with proper escaping before interpolation:api.test.js): Added a test case covering out-of-range widths (-50,100,2001) to verify they are filtered from the response.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.