Conversation
- Adds null check before calling styleSheetFromNode() to prevent 'Cannot read properties of null (reading sheet)' error - Skips stylesheets when cloneOwnerNode is not found in cloned DOM - Adds test case to verify the fix handles missing elements gracefully Fixes: PER-6656
amandeepsingh333
approved these changes
Jan 16, 2026
Shivanshu-07
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where DOM serialization crashes with
"Cannot read properties of null (reading 'sheet')"error when processing stylesheets on complex pages (e.g., Confluence).Root Cause
In
packages/dom/src/serialize-cssom.js, the code attempts to find cloned style elements usingquerySelector()but does not check if the element exists before passing it tostyleSheetFromNode(). When the element is not found in the clone,cloneOwnerNodebecomesnull, causing the error.This typically happens with:
Changes
Code Changes
cloneOwnerNodeis not found in the cloned DOMTest Changes
"skips stylesheet when cloneOwnerNode is not found in clone"to verify the fix handles missing elements gracefullyTesting
✅ All existing tests pass (212/212 on Chrome)
✅ New test case validates the fix
✅ Linting passes on modified files
Related
ignoreStyleSheetSerializationErrors: trueoptionImpact