Add cookies in config for domSnapshot#1669
Merged
chinmay-browserstack merged 3 commits intomasterfrom Jul 24, 2024
Merged
Conversation
rishigupta1599
previously approved these changes
Jul 22, 2024
rishigupta1599
requested changes
Jul 22, 2024
Contributor
rishigupta1599
left a comment
There was a problem hiding this comment.
Add testcase with config validation for DOM serialization response so that we don't miss it in future config changes as well
| }); | ||
|
|
||
| it('should contain valid dom serialization values', () => { | ||
| const dom = { |
Contributor
There was a problem hiding this comment.
This you have hardcoded so it will always pass until you remove it from config.
Expectation for test case should be PercyDOM.serialize -> response -> PercyConfig.validate(response) -> No errors
rishigupta1599
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
cookiesfield in config of domSnapshot