Skip to content

🐛 Pass auth config to node requests for fonts #969

@Robdel12

Description

@Robdel12

What is this?

In #921 we realized font responses were being corrupted through the browsers request interception API. To get around that, we now request and save fonts straight from node as a binary (no encoding). In that PR, I forgot to pass the auth config to the request that's being made, which will prevent sites behind auth from capturing fonts properly.

To fix this we need to pass the config we already have with the node request so it's properly authenticated. We should also add a debug log for when we're requesting fonts via node.

Metadata

Metadata

Assignees

Labels

🐛 bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions