Skip to content

Percy CLI Snapshot should wait for network to be idle between resizes #511

New issue
New issue
Closed
#512
Closed
Percy CLI Snapshot should wait for network to be idle between resizes#511
#512
Labels
🐛 bugSomething isn't working
@cancan101

Description

@cancan101
cancan101
opened on Aug 19, 2021

Reposting the issue from #510 (reply in thread) (/CC @Robdel12)

when the percy cli iterates over the widths:

cli/packages/core/src/percy.js

Lines 327 to 330 in feecfde

// trigger resize events for other widths
for (let width of widths) {
await page.resize({ width, height: conf.minHeight });
}

it will cause the browser to at first request a different image from the sourceset / based on CSS but then cancel that request when the image is no longer needed. You may need to make a await this.network.idle() call between sizes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    🐛 bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions