Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: percy/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.3
Choose a base ref
...
head repository: percy/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.4
Choose a head ref
  • 2 commits
  • 20 files changed
  • 1 contributor

Commits on May 12, 2022

  1. 🐛 Request fonts as binary via Node (#921) 

    * 🐛 Request fonts as binary via Node

Sometimes, through the SDKs, fonts are captured as corrupted. This has been a
long standing problem in Percy's SDKs. It turns out we cannot trust the decoding
the browser does in request interception with fonts -- a lot of the time those
fonts network responses are already corrupted by the time our SDK wants to save
the response body.

In order to work around this, we use Node to request the font files directly as
binary data. This solves all issues we've seen with fonts being captured as
corrupt.

* ✅ Add test for new `buffer` `request` option

* ✅ Add test for infering mimetype when it is `text/plain`

* ♻️ PR feedback to handle `false` mime.lookup case & add test
    @Robdel12
    Robdel12 authored May 12, 2022
    Configuration menu
    Copy the full SHA
    b31f437 View commit details
    Browse the repository at this point in the history

  2. 🔖 v1.1.4

    @Robdel12
    Robdel12 committed May 12, 2022
    Configuration menu
    Copy the full SHA
    ca09298 View commit details
    Browse the repository at this point in the history
Loading