PMM-12155 Use new option name for node_exporter#2186
Merged
Conversation
Since the new version of exporter-toolkit used in the node exporter the new option `--web.config.file` should be used instead to pass the TLS configuration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #2186 +/- ##
==========================================
- Coverage 44.77% 43.44% -1.33%
==========================================
Files 360 362 +2
Lines 36153 44100 +7947
==========================================
+ Hits 16186 19158 +2972
- Misses 18305 23259 +4954
- Partials 1662 1683 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Improve variable declaration formatting.
This was referenced May 25, 2023
Add unit test to pass the new option to the exporter and add some slight fixes to the formatting and styling.
JiriCtvrtka
approved these changes
Oct 11, 2024
idoqo
approved these changes
Oct 15, 2024
| // with the basic auth users. | ||
| var v2_27_99 = version.MustParse("2.27.99") | ||
| var ( | ||
| v2_28_00 = version.MustParse("2.28.0-0") |
Contributor
There was a problem hiding this comment.
Btw do you think we should eventually move this to features for consistency?
Contributor
There was a problem hiding this comment.
I think we need to drop it eventually :)
ademidoff
approved these changes
Oct 16, 2024
BupycHuk
reviewed
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the new version of exporter-toolkit used in the node exporter the new option
--web.config.fileshould be used instead to pass the TLS configuration.PMM-12155
Link to the Feature Build: SUBMODULES-3284