Skip to content

Percolator reset code review#384

Merged
percolator merged 34 commits intomasterfrom
percolator_reset_code_review
May 26, 2025
Merged

Percolator reset code review#384
percolator merged 34 commits intomasterfrom
percolator_reset_code_review

Conversation

@MatthewThe
Copy link
Collaborator

  • general linting (Chromium clang style) and minor refactoring
  • refactor Scores class and get rid of new specialized SanityCheck functions
  • remove Trad functions in PosteriorEstimator
  • merge Reset class with CompositionSorter
  • Find initial direction before selecting best PSM per peptide
  • Fix pseudo target assignment in cross validation set creation
  • integrated RESET in regular workflow
  • Refactored ScoreHolder and LabelType to their own files
  • refactor target/decoy labels with LabelType enum class
  • change winnerPeptides to Scores object to align with createXvalSets function
  • make Normalizer argument const where possible
  • Add style guide to docs folder
  • Remove final remnants of fido
  • Remove ubuntu debug build in favor of new build_type flag
  • Fixed triggered GitHub action builds

@MatthewThe MatthewThe requested a review from percolator August 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants