Div returns only DivisionByZeroError#138
Merged
VincentLanglet merged 2 commits intopepakriz:masterfrom Dec 23, 2020
VincentLanglet:arithmetic
Merged
Div returns only DivisionByZeroError#138VincentLanglet merged 2 commits intopepakriz:masterfrom VincentLanglet:arithmetic
VincentLanglet merged 2 commits intopepakriz:masterfrom
VincentLanglet:arithmetic
Conversation
pepakriz
approved these changes
Dec 14, 2020
Collaborator
Author
|
Any idea why is now throwing an exception @pepakriz ? |
Collaborator
Author
|
Turns out that the tests are working with phpstan 0.12.54 but not anymore since phpstan 0.12.55 Maybe you can help me on this @ondrejmirtes ? Why the two following lines have a different behaviour The code used is |
Collaborator
Author
|
Seems like for |
Collaborator
Author
|
Created phpstan/phpstan#4233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #136