Skip to content

Remove ignoreDescriptiveUncheckedExceptions#119

Merged
pepakriz merged 1 commit intopepakriz:masterfrom
VincentLanglet:draft
May 28, 2020
Merged

Remove ignoreDescriptiveUncheckedExceptions#119
pepakriz merged 1 commit intopepakriz:masterfrom
VincentLanglet:draft

Conversation

@VincentLanglet
Copy link
Copy Markdown
Collaborator

@VincentLanglet VincentLanglet commented Apr 16, 2020 •
edited
Loading

Close #116

I recommend to make a v0.11, since this is a BC-break

I allow both

private function callThrowLogic(): void
{
    $this->throwLogic();
}

And

/**
 * @throws LogicException
 */
private function throwLogic(): void
{
    throw new LogicException();
}

So the ignoreDescriptiveUncheckedExceptions is useless now ; I removed it.

@VincentLanglet VincentLanglet mentioned this pull request Apr 16, 2020
Closed
@VincentLanglet VincentLanglet marked this pull request as ready for review April 16, 2020 18:03
@VincentLanglet VincentLanglet mentioned this pull request Apr 28, 2020
Merged
@VincentLanglet
Copy link
Copy Markdown
Collaborator Author

VincentLanglet commented May 26, 2020

Hi @pepakriz Do you have time to look at my PR ? Do you need some help ?

@pepakriz
Copy link
Copy Markdown
Owner

pepakriz commented May 28, 2020

Hi @VincentLanglet . I've opened v0.11 and going to merge this. Thank you!

@pepakriz pepakriz merged commit 043cea2 into pepakriz:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Unfixable scenario with reportUnusedCatchesOfUncheckedExceptions / [Breaking change request ?] Unchecked exception

2 participants

@VincentLanglet @pepakriz