Fixed error with single timestamp query (opensearch-project#1244)

vamsimanohar · web-flow · commit ee949ccc128e · 2023-01-06T18:02:54.000-08:00
Signed-off-by: vamsi-amazon &lt;reddyvam@amazon.com&gt;

Signed-off-by: vamsi-amazon &lt;reddyvam@amazon.com&gt;
diff --git a/prometheus/src/main/java/org/opensearch/sql/prometheus/storage/querybuilder/SeriesSelectionQueryBuilder.java b/prometheus/src/main/java/org/opensearch/sql/prometheus/storage/querybuilder/SeriesSelectionQueryBuilder.java
@@ -37,7 +37,9 @@ public static String build(String metricName, Expression filterCondition) {
       SeriesSelectionExpressionNodeVisitor seriesSelectionExpressionNodeVisitor
           = new SeriesSelectionExpressionNodeVisitor();
       String selectorQuery = filterCondition.accept(seriesSelectionExpressionNodeVisitor, null);
-      return metricName + "{" + selectorQuery + "}";
+      if (selectorQuery != null) {
+        return metricName + "{" + selectorQuery + "}";
+      }
     }
     return metricName;
   }
diff --git a/prometheus/src/test/java/org/opensearch/sql/prometheus/storage/PrometheusMetricTableTest.java b/prometheus/src/test/java/org/opensearch/sql/prometheus/storage/PrometheusMetricTableTest.java
@@ -303,7 +303,7 @@ void testTimeRangeResolverWithOutEndTimeInFilter() {
         new PrometheusMetricTable(client, "prometheus_http_total_requests");
 
 
-    //Both endTime and startTime are set.
+    //Only endTime is set.
     List<NamedExpression> finalProjectList = new ArrayList<>();
     finalProjectList.add(DSL.named(VALUE, DSL.ref(VALUE, STRING)));
     finalProjectList.add(DSL.named(TIMESTAMP, DSL.ref(TIMESTAMP, ExprCoreType.TIMESTAMP)));
@@ -724,6 +724,35 @@ void testImplementWithRelationAndFilter() {
     assertEquals(List.of(VALUE, TIMESTAMP), outputFields);
   }
 
+  @Test
+  void testImplementWithRelationAndTimestampFilter() {
+    List<NamedExpression> finalProjectList = new ArrayList<>();
+    finalProjectList.add(DSL.named(VALUE, DSL.ref(VALUE, STRING)));
+    finalProjectList.add(DSL.named(TIMESTAMP, DSL.ref(TIMESTAMP, ExprCoreType.TIMESTAMP)));
+    DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
+    Long endTime = new Date(System.currentTimeMillis()).getTime();
+    PrometheusMetricTable prometheusMetricTable =
+        new PrometheusMetricTable(client, "prometheus_http_total_requests");
+    LogicalPlan logicalPlan = project(indexScan("prometheus_http_total_requests",
+        DSL.lte(DSL.ref("@timestamp", ExprCoreType.TIMESTAMP),
+            DSL.literal(
+                fromObjectValue(dateFormat.format(new Date(endTime)),
+                    ExprCoreType.TIMESTAMP)))
+    ), finalProjectList, null);
+    PhysicalPlan physicalPlan = prometheusMetricTable.implement(logicalPlan);
+    assertTrue(physicalPlan instanceof ProjectOperator);
+    assertTrue(((ProjectOperator) physicalPlan).getInput() instanceof PrometheusMetricScan);
+    PrometheusQueryRequest request
+        = ((PrometheusMetricScan) ((ProjectOperator) physicalPlan).getInput()).getRequest();
+    assertEquals((3600 / 250) + "s", request.getStep());
+    assertEquals("prometheus_http_total_requests",
+        request.getPromQl());
+    List<NamedExpression> projectList = ((ProjectOperator) physicalPlan).getProjectList();
+    List<String> outputFields
+        = projectList.stream().map(NamedExpression::getName).collect(Collectors.toList());
+    assertEquals(List.of(VALUE, TIMESTAMP), outputFields);
+  }
+
   @Test
   void testOptimize() {
     PrometheusQueryRequest prometheusQueryRequest = new PrometheusQueryRequest();

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,9 @@ public static String build(String metricName, Expression filterCondition) {`
`37`	`37`	`SeriesSelectionExpressionNodeVisitor seriesSelectionExpressionNodeVisitor`
`38`	`38`	`= new SeriesSelectionExpressionNodeVisitor();`
`39`	`39`	`String selectorQuery = filterCondition.accept(seriesSelectionExpressionNodeVisitor, null);`
`40`		`- return metricName + "{" + selectorQuery + "}";`
	`40`	`+ if (selectorQuery != null) {`
	`41`	`+ return metricName + "{" + selectorQuery + "}";`
	`42`	`+ }`
`41`	`43`	`}`
`42`	`44`	`return metricName;`
`43`	`45`	`}`