Custom synonyms #273
Merged
Custom synonyms #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2018
Closed
| 'object' == typeof config.elasticsearch.settings ){ | ||
| if( 'object' === typeof config && | ||
| 'object' === typeof config.elasticsearch && | ||
| 'object' === typeof config.elasticsearch.settings ){ |
Member
There was a problem hiding this comment.
please tell me this wasn't causing some subtle issue :P
Member
Author
There was a problem hiding this comment.
doubt it, just got caught by the linter :)
orangejulius
approved these changes
Mar 26, 2018
28f01b1 to
ce205c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this PR was branched off #272, please merge that PR first.
diff between this branch and the parent: synonyms...custom_synonyms
This PR follows on from the synonyms refactoring in #272 by adding user-modifiable synonyms files in-place, ready to be used:
$ ls -1 synonyms/custom_* synonyms/custom_admin.txt synonyms/custom_name.txt synonyms/custom_street.txtFor now, these files are empty, we will be accepting community PRs to improve the synonyms that end up in these files.
The idea with the naming is that the 'custom_name.txt' file applies to the 'name' field in the mapping, same for 'street' and 'admin'.