You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #69 I've added an update method which sets correct state of global variables after changing slider content.
Can you do a quick review? Isn't against the wallop philosophy?
I was also wondering about calling the method in the upper initialization part to save some lines of code. (but the name should be slightly different then)
Yes, that's what I was talking about.
Name reset seems more appropriate to me. I will get rid of the repetition and create a new pull request then. Is that okay?
Hi,
I've added a new commit with the fix here instead of creating a new PR. All tests are passing and I've also tested it manually. Everything is working and should be fine. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #69 I've added an update method which sets correct state of global variables after changing slider content.
Can you do a quick review? Isn't against the wallop philosophy?
I was also wondering about calling the method in the upper initialization part to save some lines of code. (but the name should be slightly different then)