Skip to content

Remove previous/next class only on items within current container#68

Merged
peduarte merged 1 commit into
peduarte:masterfrom
Djules:master
Aug 19, 2016
Merged

Remove previous/next class only on items within current container#68
peduarte merged 1 commit into
peduarte:masterfrom
Djules:master

Conversation

@Djules

@Djules Djules commented Jul 1, 2016

Copy link
Copy Markdown
Contributor

This commit fixes issue #55 when using multiple sliders on a page.

@peduarte peduarte self-assigned this Jul 13, 2016
@peduarte

Copy link
Copy Markdown
Owner

@Djules Thanks for this. Did you test all the examples in the example folder? I'm just thinking whether the change from querySelectorAll to querySelector could have broken something.

@Djules

Djules commented Jul 14, 2016

Copy link
Copy Markdown
Contributor Author

Didn't had a chance to test no, but querySelector() and querySelectorAll()[0] give the same result, isn't it?

@peduarte

Copy link
Copy Markdown
Owner

Yeah, I should do some tests before I merge this. I'll try and test this weekend, just to make sure everything is fine :)
Thanks!

@peduarte peduarte merged commit dec30c9 into peduarte:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants