Skip to content

add selector for the login submit button in nextcloud 25#64

Merged
michielbdejong merged 1 commit intomainfrom
feature/nextcloud25-cookie
Jan 20, 2023
Merged

add selector for the login submit button in nextcloud 25#64
michielbdejong merged 1 commit intomainfrom
feature/nextcloud25-cookie

Conversation

@ylebre
Copy link
Copy Markdown
Member

@ylebre ylebre commented Jan 20, 2023

This adds a CSS selector for puppeteer so it can find the 'login' submit button in Nextcloud 25.

Copy link
Copy Markdown
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielbdejong michielbdejong merged commit acc8751 into main Jan 20, 2023
@ylebre ylebre deleted the feature/nextcloud25-cookie branch January 21, 2023 15:32
@Potherca
Copy link
Copy Markdown
Member

@michielbdejong Could you also push a new version to Dockerhub?

For the long-run, should I add an MR for a GitHub workflow to automatically publish new Docker images?

@Potherca
Copy link
Copy Markdown
Member

On second thought... Automating this might make more sense to either use the GitHub Container Registry or the PDS Interop Dockerhub. 🤔

@michielbdejong
Copy link
Copy Markdown
Member

@Potherca
Copy link
Copy Markdown
Member

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants