Merged
Conversation
11 tasks
Potherca
reviewed
Oct 21, 2020
Potherca
approved these changes
Oct 23, 2020
added the solid-crud handler in for /storage/ requests
…php-solid-server into add-solid-crud-tests
…php-solid-server into add-solid-crud-tests
removing websocket dependancy here, is handled in solid-crud itself
…php-solid-server into add-solid-crud-tests
…php-solid-server into add-solid-crud-tests
michielbdejong
commented
Nov 5, 2020
Dockerfile
Outdated
| COPY site.conf /etc/apache2/sites-enabled/site.conf | ||
| RUN chown www-data /app/config | ||
| EXPOSE 443 | ||
| RUN chown www-data:www-data config |
Member
Author
There was a problem hiding this comment.
Isn't this a duplication of line 22?
Member
Author
|
The webid-provider tests are currently failing in this branch: |
Member
Author
|
The webid-provider tests passing in the ./run-solid-test-suite.sh script (again) now. |
…d-server into add-solid-crud-tests
Member
Author
|
Should be passing 61/61 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently failing 73/73 tests.