Added token generation code to support id_token#6
Merged
Conversation
added scopes added Solid enums for openIdConfiguration added TokenGenerator class as a collection of functions that should be in the php-solid-auth lib - this class needs cleanup
Potherca
requested changes
Sep 29, 2020
Member
Potherca
left a comment
There was a problem hiding this comment.
One or two minor issues that might need to be addressed now, anything else can be resolved in a later cleanup.
Potherca
approved these changes
Sep 29, 2020
Member
Potherca
left a comment
There was a problem hiding this comment.
All good now, merge at will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.