dynamic_cast -> checked_cast

pcmoritz · pcmoritz · commit 9697e692ef92 · 2019-01-29T12:36:35.000-08:00
diff --git a/cpp/src/arrow/array/builder_nested.cc b/cpp/src/arrow/array/builder_nested.cc
@@ -100,7 +100,7 @@ Status ListBuilder::FinishInternal(std::shared_ptr<ArrayData>* out) {
   }
 
   // If the type has not been specified in the constructor, infer it
-  if (!std::dynamic_pointer_cast<ListType>(type_)->value_type()) {
+  if (!arrow::internal::checked_cast<ListType&>(*type_).value_type()) {
     type_ = std::static_pointer_cast<DataType>(
         std::make_shared<ListType>(value_builder_->type()));
   }

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ Status ListBuilder::FinishInternal(std::shared_ptr<ArrayData>* out) {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`// If the type has not been specified in the constructor, infer it`
`103`		`- if (!std::dynamic_pointer_cast<ListType>(type_)->value_type()) {`
	`103`	`+ if (!arrow::internal::checked_cast<ListType&>(*type_).value_type()) {`
`104`	`104`	`type_ = std::static_pointer_cast<DataType>(`
`105`	`105`	`std::make_shared<ListType>(value_builder_->type()));`
`106`	`106`	`}`