♻️ Enable expectRevert for internal Functions#298
Merged
pcaversaccio merged 2 commits intomainfrom Jan 28, 2025
Merged
Conversation
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
|
It is also possible to use the in-line configuration as follows selectively on the failing function tests This is recommended over using the global configuration option, see: https://book.getfoundry.sh/cheatcodes/expect-revert#description |
Owner
Author
Thx, I'm aware of this possibility, but I personally prefer to enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🕓 Changelog
The Foundry PR #9537 has disabled
expectRevertforinternalfunctions by default. However, we need this functionality in theECDSATestcontract since we use theinternalfunctionto2098Formatin variousexpectReverttest calls:This PR enables
expectRevertforinternalfunctions by settingallow_internal_expect_revert = truein thefoundry.tomlfile.🐶 Cute Animal Picture