Conversation
|
Thanks! Seems like we might need to get lucky on CI. Sometimes with resolver bumps it doesn't have the resources to complete a cache-less build. Usually I can get something green on retries... |
|
It looks like we need to import |
|
That makes sense. I will try support to |
51b6641 to
d446caf
Compare
pbrisbin
left a comment
There was a problem hiding this comment.
Thanks for doing all this annoying CI work! This looks great to me... once it's Green :)
| docker: | ||
| - image: fpco/stack-build:lts | ||
| # https://github.com/haskell-works/stack-build/blob/master/minimal/Dockerfile | ||
| - image: quay.io/haskell_works/stack-build-minimal |
| weeder . | ||
| # hlint | ||
| curl -sL https://raw.github.com/ndmitchell/hlint/master/misc/travis.sh | sh -s -- --version | ||
| curl -sL https://raw.github.com/ndmitchell/hlint/master/misc/travis.sh | sh -s . |
There was a problem hiding this comment.
Can you describe the benefits of using this custom script over the simpler:
stack install --copy-compiler-tool hlint weeder
stack exec hlint
stack exec weeder
There was a problem hiding this comment.
This script is able to use always latest version hlint (and weeder).
stack install --copy-compiler-tool hlint weeder
By above instruction is installed binaries of different version depends on that resolvers (STACK_YAML env).
There was a problem hiding this comment.
Gotcha. I guess I could go either way: always latest sounds good, but using a tool appropriate for the compiler/dependencies versions under test could also be required in some edge-cases.
You've got it Green, so we can just go with this for now!
There was a problem hiding this comment.
No, I think it's OK. We'll see how it goes.
No description provided.