Skip to content

Bump deps#43

Closed
bitemyapp wants to merge 1 commit intopbrisbin:masterfrom
bitemyapp:master
Closed

Bump deps#43
bitemyapp wants to merge 1 commit intopbrisbin:masterfrom
bitemyapp:master

Conversation

@bitemyapp
Copy link
Copy Markdown

@bitemyapp bitemyapp commented Feb 28, 2018

This is mostly for the Conduit 1.3.x and Yesod 1.6.x unliftio updates.

Copy link
Copy Markdown
Owner

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you pull it back to just the bounds bump I'll merge and release right away.

package.yaml Outdated
---
name: yesod-markdown
version: '0.12.1'
version: '0.12.2'
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid the version bump in the PR. I'll do that myself (along with other things) between merge and release.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

stack.yaml Outdated
- resourcet-1.2.0
- yesod-core-1.6.1
- yesod-form-1.6.1
- yesod-persistent-1.6.0
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these strictly needed? I have no issue with bumping upper bounds, but I'd like to avoid extra-deps here since it affects CI and could give false-negatives (positives?) when checking the nightly build, etc.

Copy link
Copy Markdown
Author

@bitemyapp bitemyapp Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've discussed this with a co-maintainer before, I'll remove it for now but share the reasoning:

If I bump dependency bounds to support some new version of a library or libraries, it makes sense to me that I'd want to pin those newest versions and check that the project continues to build against them. Arguably it's slightly more necessary here as much of this isn't in a stable LTS yet.

Alternative would be to have multiple stack.yamls beyond the usual assortment for different GHC versions, one tracking nightly + pinned versions.

Also it is sort of a "show your work" thing. Shows I was actually building the library against the versions the bounds bump was permitting. You'd be surprised how often I see bounds getting bumped without people doing test builds against the newest versions permitted.

I can see why you might not want it, so I'll remove it.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backing it out. That reasoning makes sense and I will give it some more thought. I've been moving towards more comprehensive CI in #44, which includes a build on nightly. So maybe we can do something once that lands that exercises these newer versions explicitly.

I think my stance is that a CI of supported versions + nightly is enough. In other words, I'm comfortable understanding that nightly may or may not currently catch the newest versions our bounds allow, but that when it matters it will. Does that make sense?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

@pbrisbin
Copy link
Copy Markdown
Owner

Closed in #45, will try to release today, tomorrow at the latest. Thanks again!

@pbrisbin pbrisbin closed this Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants