Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

pb/github actions#79

Merged
pbrisbin merged 6 commits intomainfrom
pb/github-actions
Feb 5, 2021
Merged

pb/github actions#79
pbrisbin merged 6 commits intomainfrom
pb/github-actions

Conversation

@pbrisbin
Copy link
Owner

@pbrisbin pbrisbin commented Feb 5, 2021

  • Migrate to GitHub Actions
  • Use stable order for available-upgrade names
  • Add FIXTURES_DEBUG support
  • Track last-access in fixtures directory
  • Update fixtures

Bash associative-array ordering is dependent on many things, and will
fail the upgrade test if the curl arguments are in a different order and
no fixture is found. By tracking the names in their own array, we
preserve the order that came out of pacman -Qm. This is a slightly
better UI but, more importantly, makes the test behavior consistent.
To help debug fixtures misses.
We can use this to prune old fixtures.
This should be the last one, now that the ordering issue was resolved.
@pbrisbin
Copy link
Owner Author

pbrisbin commented Feb 5, 2021

🤔 Need to figure out how to prevent it running twice.

@aragon999
Copy link
Contributor

Mh, that is something really annoying. Unfortunately I really do not know a way except to only run on for example the main-branch and on pull requests. If you want that I can provide you with a fix for that.

Thank you for finishing the task :-)

Btw. you might want to rebase the branch onto my pull request, I am not sure but I think that then when merging both PRs should be closed.

@pbrisbin
Copy link
Owner Author

pbrisbin commented Feb 5, 2021

Yeah, I was expecting to merge this PR and close yours without merging (sorry!).

I think push: { branches: [main] } and pull_request: is actually what I want! I'll try that.

@pbrisbin pbrisbin merged commit e26ac25 into main Feb 5, 2021
@pbrisbin pbrisbin deleted the pb/github-actions branch February 5, 2021 15:59
@filipesperandio
Copy link

Hahaha master => main just broke our builder's build.

@pbrisbin
Copy link
Owner Author

pbrisbin commented Feb 5, 2021

@filipesperandio Amazing, that's hilarious.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants