Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Reformat code using shfmt#75

Merged
pbrisbin merged 1 commit intopbrisbin:masterfrom
aragon999:feature/code-reformat
Sep 3, 2019
Merged

Reformat code using shfmt#75
pbrisbin merged 1 commit intopbrisbin:masterfrom
aragon999:feature/code-reformat

Conversation

@aragon999
Copy link
Contributor

Thank you for merging.

To avoid future unnecessary commits and really see useful corrections (and of course to have a nice formatted code), I ran shfmt.
I used the same options as restyled.io would use, i.e.
shfmt -i 2 -w -ci aurget

Furthermore I quickly looked through the output of shellcheck, there are some things which could be optimized, would you be open, to accept such a pull request?

@pbrisbin
Copy link
Owner

pbrisbin commented Sep 3, 2019

Oh my goodness, thank you so much. I was planning to do this myself, to make contributions less noisy for others -- so happy to see you go for it.

there are some things which could be optimized, would you be open, to accept such a pull request?

Yes definitely. I haven't looked at the specific issues yet, so I may have some thoughts on perhaps ignoring some or resolving one way or another -- but opening up a PR would be a good first step.

I think Code Climate is wired up correctly now (it wasn't before), so we should be avoiding new ones coming in an get a nice, satisfying "Fixed N Issues" on the PR that addresses the existing ones :)

@pbrisbin pbrisbin merged commit c00df84 into pbrisbin:master Sep 3, 2019
@aragon999 aragon999 deleted the feature/code-reformat branch September 3, 2019 16:05
@aragon999
Copy link
Contributor Author

You are welcome :-) Happy that I can contribute something back to a tool I have used for such a long time.
I know these types of tasks, not really hard to do, but one cannot find time to do them.

Yes definitely. I haven't looked at the specific issues yet, so I may have some thoughts on perhaps ignoring some or resolving one way or another -- but opening up a PR would be a good first step.

Okay, I will look into that.

I think Code Climate is wired up correctly now (it wasn't before), so we should be avoiding new ones coming in an get a nice, satisfying "Fixed N Issues" on the PR that addresses the existing ones :)

Very nice :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants