This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Conversation
This reverts commit f6a976a.
This way, we can attempt to find which fixture is out of date if/when we bump into a FIXTURES_NO_RECORD error.
c170ff8 to
d083570
Compare
I can't explain why this is needed.
d083570 to
b1e85ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #67, we found an out-of-date-mock was leading to a diff in the expected
output for the upgrade test. Updating the mock this trivial, but why did it
drift?
This PR makes some improvements to help debug this:
Prevent implicit fixtures-recording on CI
This will ensure that any change that introduces drift (assuming it goes via
PR with CI) will be identified then and there. I assume the immediate feedback
will make it simple to understand why and take appropriate action.
Capture /arguments when fixtures are written
When we do encounter the drift error, we can now see which calls led to which
existing fixtures. Perhaps this will be useful for identifying cause.
Remove stale fixtures
Any fixtures without /arguments after the last complete run are no longer used
by the test suite. They are just noise and so have been removed.
Unfortunately, this will only help the next case of this, since we're not able
to capture arguments from the stale fixtures to debug, nor were we enforcing no
implicit fixture updates on CI before this PR.
Therefore, I have to give up and actually just commit the original update,
without any explanation for it.