chore: update search element to v4 design#16631
Merged
Merged
Conversation
Position both hidden and visible popup states off-screen initially to prevent brief appearance at (0,0) which caused viewport width changes during position calculation.
- Use Popup's renderButton prop for custom trigger - Add Language icon (24px globe) - Remove LocalizerLabel in favor of Button with icon - Single source of truth for button styles
- Remove LocalizerLabel spacer hack - Use flex gap for controls spacing - Clean up wrapper structure
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
PatrikKozak
requested changes
May 15, 2026
PatrikKozak
previously requested changes
May 15, 2026
PatrikKozak
left a comment
Contributor
There was a problem hiding this comment.
If you look at the collection list view design, I think the search bar needs to have a max-width as well
right now it spans full page width in list view
- Add IDs to QueryPresetBar popup buttons for test stability - Update group-by tests to use shared query-preset helpers - Update i18n test for simplified search placeholder - Update versions test to use #create-new-doc selector
JarrodMFlesch
previously approved these changes
May 18, 2026
JarrodMFlesch
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates search bar to v4.
Note: in the collection views, you will see still the unstyled
columnsandfilterbuttons. These are going to be moved outside of the search bar when the list view rework begins so just disregard them for now.